Fix NullPointerException if no binding.#1450
Open
ginyai wants to merge 1 commit intoWayofTime:1.12from
Open
Conversation
Collaborator
|
In what cases are these actually problems? By the time any of this is called, there should be a binding available. |
Author
|
https://gist.github.com/ginyai/52d413be10a456d6e0207dbd5e9f235e |
Collaborator
|
Did you ever bind a blood orb (created a soul network) when doing that? |
Author
|
@Iorce I did. And I think it is irrelevant to the exception. |
keraldi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check if the binging is null before get soul network.
Check the result of
syphonAndDamagebefore SigilBloodLight and SigilTransposition work.